This repository was archived by the owner on Jan 22, 2020. It is now read-only.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have been using this code (as a fork) for a while now and it works perfectly.
This PR adds support to allow Styled Components to be rendered on the server and adds the stylesheets to the
<head>for critical css support.https://www.styled-components.com/docs/advanced#server-side-rendering
The process of getting the stylesheets needs to be included on the server rendering part and injected into the html, it cannot be done afterwards. Thats why I needed to include it in the core of this package.
I made it configurable, so it does not run by default.
If you are interested in this code, I can add documentation and tests. Can you tell me which steps I need to make?